Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Update broken links #2499

Merged
merged 3 commits into from
Aug 17, 2022
Merged

🚨 Update broken links #2499

merged 3 commits into from
Aug 17, 2022

Conversation

CollierCZ
Copy link
Contributor

@CollierCZ CollierCZ commented Aug 15, 2022

Why

Relates to #2213

What's changed

Updated one link that no longer exists

Upgraded version of GitHub action that wasn't posting correctly. Example log.
Not sure why it was ever on version 2. An oversight on my part.

@CollierCZ CollierCZ self-assigned this Aug 15, 2022
@CollierCZ CollierCZ requested a review from trolologuy August 15, 2022 09:50
@github-actions
Copy link

Your Platform.sh environment has successfully deployed. 🚀

See the changed pages:

trolologuy
trolologuy previously approved these changes Aug 16, 2022
Copy link
Contributor

@trolologuy trolologuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much value in the magento link (see comment)

  • Final built pages are working as expected.
  • The information is correct.
  • The information is comprehensive.
  • The information is concise.
  • The information is clear.

docs/src/security/waf.md Outdated Show resolved Hide resolved
Copy link
Contributor

@trolologuy trolologuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the duplication 😵‍💫
✅ to go!

@CollierCZ CollierCZ merged commit be5e8b4 into main Aug 17, 2022
@CollierCZ CollierCZ deleted the broken-links branch August 17, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants